Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkiaSharp.Views.Forms.WPF does not target .Net Core / .Net 5 #1561

Closed
deviousasti opened this issue Dec 17, 2020 · 3 comments · Fixed by #1774
Closed

SkiaSharp.Views.Forms.WPF does not target .Net Core / .Net 5 #1561

deviousasti opened this issue Dec 17, 2020 · 3 comments · Fixed by #1774
Milestone

Comments

@deviousasti
Copy link

The SkiaSharp.Views.Forms.WPF package only targets .NETFramework 4.6.2.

<group targetFramework="net462">

However, the components they depend on all support .Net Core or .Net standard.

  • OpenTK (>= 3.1.0)
  • OpenTK.GLControl (>= 3.1.0)
  • SkiaSharp (>= 2.80.3-preview.18)
  • SkiaSharp.Views.Desktop.Common (>= 2.80.3-preview.18)
  • SkiaSharp.Views.Forms (>= 2.80.3-preview.18)
  • SkiaSharp.Views.WindowsForms (>= 2.80.3-preview.18)
  • SkiaSharp.Views.WPF (>= 2.80.3-preview.18)
  • Xamarin.Forms (>= 4.6.0.772)
  • Xamarin.Forms.Platform.WPF (>= 4.6.0.772)

It should be possible to release a .net core or .net 5 target.
I'd be willing to submit a PR if someone could point me to the build files that need updating.

@xperiandri
Copy link

Any response? @mattleibow

@mattleibow
Copy link
Contributor

I did not realise that forms was now running on netcore, so I can do that.

@mattleibow
Copy link
Contributor

I have updated to the latest v4.x of Forms. v5.0 is out, but I don't need that and also I can let people update if need be.

The next preview on the preview feed should now be .NET Core friendly :)

@mattleibow mattleibow added this to the v2.88.0 milestone May 22, 2022
@mattleibow mattleibow moved this to Done in SkiaSharp Backlog May 22, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants