You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Previously, calling SKTypeface.GetGlyphs(...) would basically cast the incoming pointer to the type specified by the encoding. So, for a UTF32 encoding, it took the pointer and cast to uint32_t*. The new way is to "convert" to UTF32.
What actually happened under the hood was that the typeface handed all encodings. However, in v2, this was changed and only handles UTF32, so I redirected the logic to SKFont which does the conversion. This was incorrect.
Description
Previously, calling
SKTypeface.GetGlyphs(...)
would basically cast the incoming pointer to the type specified by the encoding. So, for a UTF32 encoding, it took the pointer and cast touint32_t*
. The new way is to "convert" to UTF32.This is a breaking change and needs to be fixed.
Old: https://github.com/mono/skia/blob/v1.68.3/src/ports/SkFontHost_win.cpp#L2044
New: https://github.com/mono/skia/blob/v2.80.0/src/ports/SkFontHost_win.cpp#L1897
What actually happened under the hood was that the typeface handed all encodings. However, in v2, this was changed and only handles UTF32, so I redirected the logic to
SKFont
which does the conversion. This was incorrect.Code
See code in: toptensoftware/RichTextKit#15
Expected Behavior
GetGlyphs(int*, Utf32)
should not convert the data to UTF32.Actual Behavior
Conversion.
Basic Information
Screenshots
N/A
Reproduction Link
toptensoftware/RichTextKit#15
The text was updated successfully, but these errors were encountered: