fix: caret and word shift on wikipedia (and poetry) funbox (@sanidhyas3s) #5819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miodec
requested changes
Aug 27, 2024
Comment on lines
+363
to
372
| // await for addWord should not hold other actions within this function hence should be called last | ||
| if ( | ||
| Config.mode === "time" || | ||
| Config.mode === "words" || | ||
| Config.mode === "custom" || | ||
| Config.mode === "quote" | ||
| ) { | ||
| await TestLogic.addWord(); | ||
| } | ||
| } |
There was a problem hiding this comment.
This change will break the plus zero funbox because youre updating active element before adding a word.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix buggy behaviour when using wikipedia and poetry funbox. The issue was caused when we type faster than words are added and the index update (or some other update) is waiting for it and hence is altered by being triggered later, now in the test logic, we shift adding more words to the end of the function where it is called, hence it should hold any index update.
Tested to fix the bug (when adding words was forced by hardcoding), the bug doesn't exist with this PR, existed without.
Checks
Closes #5797