Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README - added plugin dev override #468

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Conversation

abner-dou
Copy link
Contributor

Description

Added block in README about how to override provider for dev plugin use

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

Copy link
Contributor

@leofigy leofigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abner-dou
Copy link
Contributor Author

Hi @themantissa , I'm trying to add a mongo reviewer to this PR using apiX or @apiX but nothing appears :/
this may be a permissions issue?

@themantissa
Copy link
Collaborator

@abner-dou just tried and it's actually mongodb/apix try that and see if it works please.

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this! LGTM

@themantissa themantissa requested review from a team and threebee and removed request for a team June 3, 2021 21:19
Copy link

@threebee threebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abner-dou abner-dou merged commit 8b26cb0 into master Jun 4, 2021
@abner-dou abner-dou deleted the update-readme-file branch June 4, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants