INTMDB-206 Documentation and example updates #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themantissa
requested changes
May 7, 2021
| @@ -15,6 +15,8 @@ The MongoDB Atlas provider offers two paths to perform an authorization for a cl | |||
| * A two resource path, consisting of `mongodbatlas_cloud_provider_access_setup` and `mongodbatlas_cloud_provider_access_authorization`. The first resource, `mongodbatlas_cloud_provider_access_setup`, only generates | |||
| the initial configuration (create, delete operations). The second resource, `mongodbatlas_cloud_provider_access_authorization`, helps to perform the authorization using the role_id of the first resource. This path is helpful in a multi-provider Terraform file, and allows a single and decoupled apply. | |||
|
|
|||
| -> **IMPORTANT** If it is needed to migrate from the single resource to the two resource paths see the [migration guide](https://registry.terraform.io/providers/mongodb/mongodbatlas/latest/docs/guides/0.9.1-upgrade-guide#migration-to-cloud-provider-access-setup) | |||
There was a problem hiding this comment.
I would edit this slightly to:
If you want to move from the single resource path to the two resources path see the migration guide
| @@ -57,6 +57,15 @@ resource "mongodbatlas_encryption_at_rest" "test" { | |||
| } | |||
| ``` | |||
|
|
|||
| **NOTE** in case using the `cloud_provider_access_setup` and `cloud_provider_access_authorization`, could be a use case where it needs to define the `depends_on` statement for these two resources, because terraform is not able to infer. | |||
There was a problem hiding this comment.
Suggested edit that may help clarify:
NOTE if using the two resources path for cloud provider access, cloud_provider_access_setup and cloud_provider_access_authorization, you may need to to define a depends_on statement for these two resources because terraform is not able to infer the dependency.
coderGo93
reviewed
May 10, 2021
coderGo93
reviewed
May 10, 2021
| variable "atlas_region" { | ||
| default = "US_EAST_1" | ||
| description = "Atlas Region" | ||
| } |
There was a problem hiding this comment.
same GH linter error as before
coderGo93
reviewed
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the documentation guide for migration for the cloud_provider_access_setup and adding one example to using it with the encryption_at_rest for aws.
Link to any related issue(s):
#451
#409
Type of change:
Required Checklist:
Further comments