Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test or TestAccResourceMongoDBAtlasDatabaseUser_withAWSIAMType with #432

Merged
merged 2 commits into from
Apr 15, 2021

Conversation

pitakill
Copy link
Contributor

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Add test case to cover import for AWS db user

Link to any related issue(s):

https://jira.mongodb.org/browse/INTMDB-156

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

import

1. Why is this change necessary?
Test for a import is a nice to have

2. How does it address the issue?
Test the function with the import for a matching scenario

3. What side effects does this change have?
None known
@pitakill pitakill requested review from coderGo93 and leofigy April 12, 2021 01:52
@pitakill pitakill self-assigned this Apr 12, 2021
1. Why is this change necessary?
Modular testing

2. How does it address the issue?
Make the username variable in that particular test dependentant on a env
var

3. What side effects does this change have?
None
@pitakill pitakill requested review from leofigy and themantissa April 14, 2021 16:40
Copy link
Contributor

@leofigy leofigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@leofigy leofigy added the run-testacc To run acceptance tests label Apr 14, 2021
@leofigy leofigy merged commit 135e66f into master Apr 15, 2021
@themantissa themantissa deleted the INTMDB-156 branch August 10, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement run-testacc To run acceptance tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants