Add examples creating user with aws_iam_type #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexsergeyev thank you for the submission. As soon as we get a chance we'll verify the CLA and review. |
|
@alexsergeyev this is a good catch and I'd like to approve and merge but I can't seem to find your name on the CLA. Did you sign under a different name? https://www.mongodb.com/legal/contributor-agreement |
|
@themantissa Could you recheck CLA? |
|
@alexsergeyev I am. Sorry for the delay but hopefully will have verification soon! |
|
@alexsergeyev thank you for standing by, I've finally been able to confirm the CLA. I'll approve and merge now. Thank you again. Also note this will go out into docs with the next release so you'll see it then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
username field reused for multiple cases including aws_arn. that's not clear from documentation where user_arn/role_arn should be posted.
Link to any related issue(s):
Type of change:
Required Checklist:
Further comments
https://github.com/mongodb/terraform-provider-mongodbatlas/blob/master/mongodbatlas/resource_mongodbatlas_database_user_test.go#L121