Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-153: Create 0.8.0-upgrade-guide.html.markdown #384

Merged
merged 4 commits into from
Jan 20, 2021
Merged

INTMDB-153: Create 0.8.0-upgrade-guide.html.markdown #384

merged 4 commits into from
Jan 20, 2021

Conversation

themantissa
Copy link
Collaborator

Description

Guide for IAM creds/roles switch needs and private link deprecation

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • [ x] Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@themantissa
Create 0.8.0-upgrade-guide.html.markdown
c52a221 
Guide for IAM creds/roles switch needs and private link deprecation
leofigy
leofigy approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@leofigy leofigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Hi @coderGo93 , could you please check as well.

@themantissa themantissa changed the title Create 0.8.0-upgrade-guide.html.markdown INTMDB-153: Create 0.8.0-upgrade-guide.html.markdown Jan 19, 2021
coderGo93
coderGo93 approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@coderGo93 coderGo93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shum
shum requested changes Jan 20, 2021
View reviewed changes
Copy link
Collaborator

@shum shum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes suggested! Looks good!

website/docs/guides/0.8.0-upgrade-guide.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/0.8.0-upgrade-guide.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/0.8.0-upgrade-guide.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/0.8.0-upgrade-guide.html.markdown Outdated Show resolved Hide resolved
website/docs/guides/0.8.0-upgrade-guide.html.markdown Show resolved Hide resolved
website/docs/guides/0.8.0-upgrade-guide.html.markdown Show resolved Hide resolved
website/docs/guides/0.8.0-upgrade-guide.html.markdown Show resolved Hide resolved
@themantissa themantissa requested a review from shum January 20, 2021 19:31
shum
shum approved these changes Jan 20, 2021
View reviewed changes
Copy link
Collaborator

@shum shum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny things. LGTM!!

website/docs/guides/0.8.0-upgrade-guide.html.markdown Show resolved Hide resolved
website/docs/guides/0.8.0-upgrade-guide.html.markdown Outdated Show resolved Hide resolved
@themantissa themantissa merged commit b44afaa into master Jan 20, 2021
@themantissa themantissa deleted the add-upgrade-guide-v8 branch August 10, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofigy leofigy leofigy approved these changes

@coderGo93 coderGo93 coderGo93 approved these changes

@shum shum shum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@themantissa @shum @coderGo93 @leofigy