chore: Upgrades advanced_cluster resource to auto-generated SDK

.github/workflows/acceptance-tests-runner.yml

@@ -123,15 +123,15 @@ jobs:
     outputs:
       cluster_outage_simulation: ${{ steps.filter.outputs.cluster_outage_simulation == 'true' || env.mustTrigger == 'true' }}
       advanced_cluster: ${{ steps.filter.outputs.advanced_cluster == 'true' || env.mustTrigger == 'true' }}
-      cluster: ${{ steps.filter.outputs.cluster == 'true' || env.mustTrigger == 'true' }}
-      search_deployment: ${{ steps.filter.outputs.search_deployment == 'true' || env.mustTrigger == 'true' }}
+      cluster: false # TEMPORARY, WILL BE REVERTED BEFORE MERGE
+      search_deployment: false # TEMPORARY, WILL BE REVERTED BEFORE MERGE
       stream: ${{ steps.filter.outputs.stream == 'true' || env.mustTrigger == 'true' }}
       generic: ${{ steps.filter.outputs.generic == 'true' || env.mustTrigger == 'true' }}
-      backup: ${{ steps.filter.outputs.backup == 'true' || env.mustTrigger == 'true' }}
+      backup: false # TEMPORARY, WILL BE REVERTED BEFORE MERGE
       project: ${{ steps.filter.outputs.project == 'true' || env.mustTrigger == 'true' }}
-      serverless: ${{ steps.filter.outputs.serverless == 'true' || env.mustTrigger == 'true' }}
-      network: ${{ steps.filter.outputs.network == 'true' || env.mustTrigger == 'true' }}
-      config: ${{ steps.filter.outputs.config == 'true' || env.mustTrigger == 'true' }}
+      serverless: false # TEMPORARY, WILL BE REVERTED BEFORE MERGE
+      network: false # TEMPORARY, WILL BE REVERTED BEFORE MERGE
+      config: false # TEMPORARY, WILL BE REVERTED BEFORE MERGE
       assume_role: ${{ steps.filter.outputs.assume_role == 'true' || env.mustTrigger == 'true' }}
       event_trigger: ${{ steps.filter.outputs.event_trigger == 'true' || env.mustTrigger == 'true' }}
       search_index: ${{ steps.filter.outputs.search_index == 'true' || env.mustTrigger == 'true' }}

.github/workflows/migration-tests.yml

@@ -55,19 +55,19 @@ jobs:
       mustTrigger: ${{ github.event_name == 'schedule' || (github.event_name == 'workflow_dispatch' && inputs.test_group == '')  }}
     outputs:
       project: ${{ steps.filter.outputs.project == 'true' || env.mustTrigger == 'true' }}
-      config: ${{ steps.filter.outputs.config == 'true' || env.mustTrigger == 'true' }}
+      config: false # TEMPORARY, WILL BE REVERTED BEFORE MERGE
       advanced_cluster: ${{ steps.filter.outputs.advanced_cluster == 'true' || env.mustTrigger == 'true' }}
-      backup: ${{ steps.filter.outputs.backup == 'true' || env.mustTrigger == 'true' }}
+      backup: false # TEMPORARY, WILL BE REVERTED BEFORE MERGE
       stream: ${{ steps.filter.outputs.stream == 'true' || env.mustTrigger == 'true' }}
       federated: ${{ steps.filter.outputs.federated == 'true' || env.mustTrigger == 'true' }}
-      search_deployment: ${{ steps.filter.outputs.search_deployment == 'true' || env.mustTrigger == 'true' }}
+      search_deployment: false # TEMPORARY, WILL BE REVERTED BEFORE MERGE
       generic: ${{ steps.filter.outputs.generic == 'true' || env.mustTrigger == 'true' }}
-      network: ${{ steps.filter.outputs.network == 'true' || env.mustTrigger == 'true' }}
+      network: false # TEMPORARY, WILL BE REVERTED BEFORE MERGE
       encryption: ${{ steps.filter.outputs.encryption == 'true' || env.mustTrigger == 'true' }}
-      serverless: ${{ steps.filter.outputs.serverless == 'true' || env.mustTrigger == 'true' }}
+      serverless: false # TEMPORARY, WILL BE REVERTED BEFORE MERGE
       data_lake: ${{ steps.filter.outputs.data_lake == 'true' || env.mustTrigger == 'true' }}
       cluster_outage_simulation: ${{ steps.filter.outputs.cluster_outage_simulation == 'true' || env.mustTrigger == 'true' }}
-      cluster: ${{ steps.filter.outputs.cluster == 'true' || env.mustTrigger == 'true' }}
+      cluster: false # TEMPORARY, WILL BE REVERTED BEFORE MERGE
     steps:
     - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
     - uses: dorny/paths-filter@0bc4621a3135347011ad047f9ecf449bf72ce2bd

internal/common/conversion/flatten_expand.go

@@ -6,29 +6,29 @@ import (
 	"go.mongodb.org/atlas-sdk/v20231115006/admin"
 )
 
-func FlattenLinks(links []admin.Link) []map[string]any {
-	ret := make([]map[string]any, len(links))
+func FlattenLinks(links []admin.Link) []map[string]string {
+	ret := make([]map[string]string, len(links))
 	for i, link := range links {
-		ret[i] = map[string]any{
+		ret[i] = map[string]string{
 			"href": link.GetHref(),
 			"rel":  link.GetRel(),
 		}
 	}
 	return ret
 }
 
-func FlattenTags(tags []admin.ResourceTag) []map[string]any {
-	ret := make([]map[string]any, len(tags))
+func FlattenTags(tags []admin.ResourceTag) []map[string]string {
+	ret := make([]map[string]string, len(tags))
 	for i, tag := range tags {
-		ret[i] = map[string]any{
+		ret[i] = map[string]string{
 			"key":   tag.GetKey(),
 			"value": tag.GetValue(),
 		}
 	}
 	return ret
 }
 
-func ExpandTagsFromSetSchema(d *schema.ResourceData) []admin.ResourceTag {
+func ExpandTagsFromSetSchema(d *schema.ResourceData) *[]admin.ResourceTag {
 	list := d.Get("tags").(*schema.Set)
 	ret := make([]admin.ResourceTag, list.Len())
 	for i, item := range list.List() {
@@ -38,7 +38,7 @@ func ExpandTagsFromSetSchema(d *schema.ResourceData) []admin.ResourceTag {
 			Value: StringPtr(tag["value"].(string)),
 		}
 	}
-	return ret
+	return &ret
 }
 
 func ExpandStringList(list []any) (res []string) {

internal/common/conversion/type_conversion.go

@@ -29,6 +29,12 @@ func TimeToString(t time.Time) string {
 	return t.UTC().Format(time.RFC3339Nano)
 }
 
+// StringToTime is the opposite to TimeToString, returns ok if conversion is possible.
+func StringToTime(str string) (time.Time, bool) {
+	ret, err := time.Parse(time.RFC3339Nano, str)
+	return ret, err == nil
+}
+
 func Int64PtrToIntPtr(i64 *int64) *int {
 	if i64 == nil {
 		return nil

internal/common/conversion/type_conversion_test.go

@@ -5,28 +5,39 @@ import (
 	"time"
 
 	"github.com/mongodb/terraform-provider-mongodbatlas/internal/common/conversion"
+	"github.com/stretchr/testify/assert"
 )
 
-func TestTimeToStringWithoutNanos(t *testing.T) {
+func TestTimeWithoutNanos(t *testing.T) {
 	inputTime := time.Date(2023, time.July, 18, 16, 12, 23, 0, time.UTC)
 	expectedOutput := "2023-07-18T16:12:23Z"
 
 	result := conversion.TimeToString(inputTime)
+	assert.Equal(t, expectedOutput, result)
 
-	if result != expectedOutput {
-		t.Errorf("TimeToString(%v) = %v; want %v", inputTime, result, expectedOutput)
-	}
+	expectedTime, ok := conversion.StringToTime(result)
+	assert.True(t, ok)
+	assert.Equal(t, expectedTime, inputTime)
 }
 
-func TestTimeToStringWithNanos(t *testing.T) {
+func TestTimeWithNanos(t *testing.T) {
 	inputTime := time.Date(2023, time.July, 18, 16, 12, 23, 456_000_000, time.UTC)
 	expectedOutput := "2023-07-18T16:12:23.456Z"
 
 	result := conversion.TimeToString(inputTime)
+	assert.Equal(t, expectedOutput, result)
 
-	if result != expectedOutput {
-		t.Errorf("TimeToString(%v) = %v; want %v", inputTime, result, expectedOutput)
-	}
+	expectedTime, ok := conversion.StringToTime(result)
+	assert.True(t, ok)
+	assert.Equal(t, expectedTime, inputTime)
+}
+
+func TestStringToTimeInvalid(t *testing.T) {
+	_, ok := conversion.StringToTime("")
+	assert.False(t, ok)
+
+	_, ok = conversion.StringToTime("123")
+	assert.False(t, ok)
 }
 
 func TestIsStringPresent(t *testing.T) {