Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Enable Acceptance test in CI for mongodbatlas_federated_settings_identity_provider #1895

Merged
merged 15 commits into from
Feb 2, 2024

Conversation

oarbusi
Copy link
Collaborator

@oarbusi oarbusi commented Jan 31, 2024

Description

Enable acceptance test for federated_settings_identity_provider in the CI pipeline
Link to any related issue(s): https://jira.mongodb.org/browse/CLOUDP-220799

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@oarbusi oarbusi changed the title test: Enable Acceptance test in CI for federated_settings_identity_provider test: Enable Acceptance test in CI for mongodbatlas_federated_settings_identity_provider Feb 1, 2024
@oarbusi oarbusi marked this pull request as ready for review February 2, 2024 08:42
@oarbusi oarbusi requested a review from a team as a code owner February 2, 2024 08:42
@lantoli
Copy link
Member

lantoli commented Feb 2, 2024

in PR description just need to say CLOUDP-220799, not the full url/link

Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great to have this running in the CI 💯

.github/workflows/acceptance-tests.yml Outdated Show resolved Hide resolved
@oarbusi oarbusi merged commit 5117c14 into master Feb 2, 2024
37 checks passed
@oarbusi oarbusi deleted the CLOUDP-220799 branch February 2, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants