chore: Unifies SDK connection getting in tests #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantoli
commented
Jan 23, 2024
| @@ -311,7 +310,7 @@ func TestAccConfigRSAlertConfiguration_importBasic(t *testing.T) { | |||
| ImportStateIdFunc: importStateProjectIDFunc(resourceName), | |||
| ImportState: true, | |||
| ImportStateVerify: true, | |||
| ImportStateVerifyIgnore: []string{"project_id"}, | |||
| ImportStateVerifyIgnore: []string{"project_id", "updated"}, | |||
There was a problem hiding this comment.
fix flaky test where updated attribute sometimes differ in a second
…ot differ in a second.
example:
error=
| ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
|
| \u00a0\u00a0map[string]string{
| -\u00a0\t"updated": "2024-01-23T01:33:43Z",
| +\u00a0\t"updated": "2024-01-23T01:33:42Z",
| \u00a0\u00a0}
lantoli
force-pushed
the
CLOUDP-224848_test_conn
branch
from
306bacd to
c8e6874
Compare
AgustinBettati
approved these changes
Jan 23, 2024
internal/provider/provider.go
Outdated
Comment on lines
457
to
459
| // muxedProviderFactoryFn creates mux provider using existing sdk v2 provider passed as parameter and creating new instance of framework provider. | ||
| // Used in testing where existing sdk v2 provider has to be used. | ||
| func MuxedProviderFactoryFn(sdkV2Provider *sdkv2schema.Provider) func() tfprotov6.ProviderServer { | ||
| func muxedProviderFactoryFn(sdkV2Provider *sdkv2schema.Provider) func() tfprotov6.ProviderServer { |
There was a problem hiding this comment.
Since this function receiving an existing sdkV2Provider is no longer needed, could we define this logic directly in MuxedProviderFactory() and remove this function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unifies SDK connection getting in tests.
Before this PR, SDK connection in tests is got in different ways, not all of them work for migration tests. Here we get the connection in the same way independently of the test type.
Link to any related issue(s): https://jira.mongodb.org/browse/CLOUDP-224848
Type of change:
Required Checklist:
Further comments