feat: Adds new ip_addresses computed attribute in mongodbatlas_project resource and data sources

[AgustinBettati]

Description

Link to any related issue(s): CLOUDP-215106

Includes new computed attribute ip_addresses in project resource and data sources.

Resulting terraform state for a project with no clusters

{
    "mode": "data",
    "type": "mongodbatlas_project",
    "provider": "provider[\"registry.terraform.io/mongodb/mongodbatlas\"]",
    "instances": [
        {
            "schema_version": 0,
            "attributes": {
                "cluster_count": 0,
                "created": "2023-10-24T09:22:24Z",
                "id": "65378ccff055c147c22c7a45",
                "ip_addresses": {
                    "services": {
                        "clusters": []
                    }
                },
                ...
            }
        }
    ]
}

Resulting terraform state for a project with clusters

(IP values obfuscated manually)

{
    "mode": "data",
    "type": "mongodbatlas_project",
    "name": "test",
    "provider": "provider[\"registry.terraform.io/mongodb/mongodbatlas\"]",
    "instances": [
        {
            "schema_version": 0,
            "attributes": {
                "cluster_count": 1,
                "created": "2023-10-10T09:07:21Z",
                "id": "65251446ae5f3f6ec7968b13",
                "ip_addresses": {
                    "services": {
                        "clusters": [
                            {
                                "cluster_name": "Cluster0",
                                "inbound": [
                                    "13.53.*****",
                                    "13.50.*****",
                                    "13.48.*****"
                                ],
                                "outbound": [
                                    "13.53.*****",
                                    "13.50.*****",
                                    "13.48.*****"
                                ]
                            }
                        ]
                    }
                }
                ...
            }
        }
    ]
}

Type of change:

• Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
• New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
• Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
• This change requires a documentation update
• Documentation fix/enhancement

Required Checklist:

• I have signed the MongoDB CLA
• I have read the contribution guidelines
• I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
• I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
• I have added any necessary documentation (if appropriate)
• I have run make fmt and formatted my code
• If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

[AgustinBettati]

mockery config file was not working as expected, only the last package (in this case advancedcluster) was used for generating mocks.

[AgustinBettati]

Adjusting format of defining nested schema in other section, generates consistency with project resource documentation and how tfplugindocs also defines nested schemas.

[marcosuma]

nice!

[lantoli]

can something be used from project_ip_access_list resource/ds or they're different concepts?

[AgustinBettati]

They seem to be different concepts. From testing I can see that it provides the IP address of each cluster node. This scope document gives some more details as to users that would leverage these ip addresses

[lantoli]

can some part of the schema be reused from the RS or it's hard because here all are Computed?

[AgustinBettati]

The main limitation is that they are different schema types, terraform-plugin-framework/datasource/schema and terraform-plugin-framework/resource/schema respectively.

[lantoli]

what is services adding as opposed to not having it?

[AgustinBettati]

Here I am sticking to the structure defined in the API. From the scope doc:

We will design the API schema in a way that's extensible (similar to the way SRE is designing theirs) so we can just add the bare minimum for now and future projects can add more.

I believe sticking to this structure will avoid breaking changes in the future as more services are added. Also synced with Zuhair on this in the jira comments.

[lantoli]

it seems like IP addresses are associated to clusters in the project? wouldn't it make more sense then that IP addresses are returned in the clustest/adv_cluster resource instead of project? or in addition to be returned in project?

[AgustinBettati]

This a fair point. The main reason I see for including in the project resource is due to the endpoint being tagged in the project section (https://www.mongodb.com/docs/atlas/reference/api-resources-spec/v2/#tag/Projects/operation/returnAllIPAddresses).

[lantoli]

shouldn't we check errors or it's ok because it's in tests?

[AgustinBettati]

not concerned for creating the test value, however adjusted model functions to return diags and check in the unit tests that no errors are encountered.