Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Allows to to run acceptance tests for a published Atlas provider version #1789

Merged
merged 11 commits into from
Dec 22, 2023
Merged

chore: Allows to to run acceptance tests for a published Atlas provider version #1789

merged 11 commits into from
Dec 22, 2023

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Dec 21, 2023 •
edited
Loading

Description

Allows to to run acceptance tests for a published Atlas provider version.

This allows to run acceptance test for already published MongoDB Atlas provider releases for a Terraform CLI version and check that it's compatible.

Link to any related issue(s): https://jira.mongodb.org/browse/CLOUDP-219089

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@lantoli lantoli marked this pull request as ready for review December 21, 2023 13:27
@lantoli lantoli requested a review from a team as a code owner December 21, 2023 13:27
lantoli
lantoli commented Dec 21, 2023
View reviewed changes
.github/workflows/test-suite.yml Outdated
secrets: inherit
uses: ./.github/workflows/acceptance-tests.yml
with:
ref: 'v1.14.0'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending to calculate instead of hardcoding

AgustinBettati
AgustinBettati reviewed Dec 21, 2023
View reviewed changes
.github/workflows/test-suite.yml Outdated
@@ -34,8 +34,16 @@ jobs:
secrets: inherit
uses: ./.github/workflows/cleanup-test-env.yml

acc-tests-latest-published:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am struggling to see the value of adding this job to run daily, given that the results will be the same unless there is a new patch release from TF.
If you can provide more context in the PR or reference where this requirement was discussed that would be great. I am thinking why we cannot rely on our master branch to see if the latest patch version of TF is breaking some functionality in our provider.

Copy link
Member Author

@lantoli lantoli Dec 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the use case here is that Hashicorp releases a new version, e.g. 1.6.7 and breaks our latest published version, e.g. 1.14.0. it's true that results won't change while Hashicorp doesn't publish a new version. But the alternative is that we have to be pending (or automate?) when a new version is published and then run on demand.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zuhairahmed what do you think?
alternatively we can do that, don't run every night but on demand when we know that a new Hashicorp version came out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AgustinBettati at the moment I'll leave only the option to run it manually

@lantoli lantoli changed the title chore: Allows to to run tests for a published Atlas provider version chore: Allows to to run acceptance tests for a published Atlas provider version Dec 21, 2023
AgustinBettati
AgustinBettati approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lantoli lantoli merged commit 2c96c61 into master Dec 22, 2023
31 checks passed
@lantoli lantoli deleted the CLOUDP-219089_published_version branch December 22, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgustinBettati AgustinBettati AgustinBettati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lantoli @AgustinBettati