Cannot import export bucket - bad state id encoding

[ghost]

Terraform CLI and Terraform MongoDB Atlas Provider Version

Terraform v1.1.7
on darwin_amd64
+ provider registry.terraform.io/mongodb/mongodbatlas v1.3.1

Terraform Configuration File

resource "mongodbatlas_cloud_backup_snapshot_export_bucket" "this" {
  project_id     = var.atlas_project_id
  iam_role_id    = mongodbatlas_cloud_provider_access_setup.this.role_id
  bucket_name    = module.s3_bucket.s3_bucket_id
  cloud_provider = "AWS"

  depends_on = [
    mongodbatlas_cloud_provider_access_authorization.this
  ]
}

Steps to Reproduce

terraform import "module.atlas_backup_export[0].mongodbatlas_cloud_backup_snapshot_export_bucket.this" someProjectId-someBucketId

Expected Behavior

The existing export bucket should have been successfully imported into state.

Actual Behavior

module.atlas_backup_export[0].mongodbatlas_cloud_backup_snapshot_export_bucket.this: Importing from ID "someProjectId-someBucketId"...
module.atlas_backup_export[0].mongodbatlas_cloud_backup_snapshot_export_bucket.this: Import prepared!
  Prepared mongodbatlas_cloud_backup_snapshot_export_bucket for import
module.atlas_backup_export[0].mongodbatlas_cloud_backup_snapshot_export_bucket.this: Refreshing state... [id=theBase64EncodedStateId]

│ Error: error getting snapshot export backup information: bucketID is invalid because must be set
│ 
│ 

I believe the import fails because the import state function passes the wrong map keys to the encodeStateID function here:

terraform-provider-mongodbatlas/mongodbatlas/resource_mongodbatlas_cloud_backup_snapshot_export_bucket.go

Lines 158 to 161 in 778064b

	d.SetId(encodeStateID(map[string]string{
	"project_id": *projectID,
	"name": *id,
	}))

And the read function is looking for bucketID in the key id in the decoded id map?

terraform-provider-mongodbatlas/mongodbatlas/resource_mongodbatlas_cloud_backup_snapshot_export_bucket.go

Lines 89 to 108 in 778064b

	func resourceMongoDBAtlasCloudBackupSnapshotExportBucketRead(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
	// Get client connection.
	conn := meta.(*MongoDBClient).Atlas
	ids := decodeStateID(d.Id())
	projectID := ids["project_id"]
	bucketID := ids["id"]
	exportBackup, _, err := conn.CloudProviderSnapshotExportBuckets.Get(ctx, projectID, bucketID)
	if err != nil {
	// case 404
	// deleted in the backend case
	reset := strings.Contains(err.Error(), "404") && !d.IsNewResource()
	if reset {
	d.SetId("")
	return nil
	}
	return diag.Errorf("error getting snapshot export backup information: %s", err)
	}

Debug Output

References

[themantissa]

Thank you @sophos-daniels for the complete issue. We will look into it.

Internal ticket: INTMDB-315

[themantissa]

@sophos-daniels this is corrected in version 1.4.0, which is now available as a pre-release version in this repo. We will release it tomorrow.

[themantissa]

@sophos-daniels this is now out in 1.4.1.

[ghost]

Thank you!