Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MONGOSH-1906 Add OIDC workforce auth requirements docs #1731

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

addaleax
Copy link
Contributor

Thank you @alexbevi for the support here 🙂

@addaleax addaleax requested a review from a team as a code owner November 14, 2024 14:41
@addaleax addaleax requested review from JamesKovacs and removed request for a team November 14, 2024 14:41
docs/workforce-human-oidc-auth.md Outdated Show resolved Hide resolved
docs/workforce-human-oidc-auth.md Outdated Show resolved Hide resolved
@addaleax addaleax requested a review from a team as a code owner November 14, 2024 15:37
@blink1073 blink1073 self-requested a review November 14, 2024 16:31
@addaleax addaleax changed the title Add OIDC workforce auth requirements docs MONGOSH-1906 MONGOSH-1906 Add OIDC workforce auth requirements docs Nov 19, 2024
Copy link
Contributor

@pmeredit pmeredit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -46,5 +46,8 @@
# URI Options
/source/uri-options/ @mongodb/dbx-spec-owners-uri-options

# Workforce OIDC
/docs/workforce-human-oidc-auth.md @mongodb/dbx-spec-owners-workforce-oidc

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder to create the team

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, and I'm not sure why GH is complaining: https://github.com/orgs/mongodb/teams/dbx-spec-owners-workforce-oidc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, looks like the parent team needs to be set to dbx-spec-reviewers, I've requested that + the request is pending rn

docs/workforce-human-oidc-auth.md Outdated Show resolved Hide resolved
docs/workforce-human-oidc-auth.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants