Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-5971): attach v to createIndexes command when version is specified #4043

Merged
merged 4 commits into from
Mar 20, 2024
Merged

fix(NODE-5971): attach v to createIndexes command when version is specified #4043

merged 4 commits into from
Mar 20, 2024

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Mar 18, 2024 •
edited
Loading

Description

What is changing?

createIndex and createIndexes now support specifying an index version with the version option.

One note is that createIndexes() requires that users specify the version as a part of their index specification - a version provided as a part of the options is ignored. This behavior is consistent with other index options provided to createIndexes.

Is there new documentation needed for these changes?

What is the motivation for this change?

(release highlight left empty since v is an undocumented feature, no need for it to appear in our release notes)

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson force-pushed the NODE-5971-index-v-option branch from 10b0a19 to 79084c8 Compare March 19, 2024 14:11
@baileympearson baileympearson changed the title misc test fixes fix(NODE-5971): attach v to createIndexes command when version is specified Mar 19, 2024
@baileympearson baileympearson marked this pull request as ready for review March 19, 2024 14:34
@W-A-James W-A-James self-requested a review March 19, 2024 20:07
@W-A-James W-A-James self-assigned this Mar 19, 2024
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 19, 2024
W-A-James
W-A-James reviewed Mar 19, 2024
View reviewed changes
Copy link
Contributor

@W-A-James W-A-James left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one optional change

src/operations/indexes.ts Outdated Show resolved Hide resolved
W-A-James
W-A-James previously approved these changes Mar 20, 2024
View reviewed changes
@W-A-James W-A-James added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Mar 20, 2024
nbbeeken
nbbeeken reviewed Mar 20, 2024
View reviewed changes
src/operations/indexes.ts Outdated Show resolved Hide resolved
@W-A-James W-A-James merged commit 1879a04 into main Mar 20, 2024
20 of 26 checks passed
@W-A-James W-A-James deleted the NODE-5971-index-v-option branch March 20, 2024 20:56
@github-actions github-actions bot mentioned this pull request Mar 20, 2024
Merged
aditi-khare-mongoDB pushed a commit that referenced this pull request Apr 5, 2024
@baileympearson @aditi-khare-mongoDB
fix(NODE-5971): attach v to createIndexes command when version is…
819b06d 
… specified (#4043)
@NotZarifGithub NotZarifGithub mentioned this pull request May 24, 2024
Open
@kazimanzurrashid kazimanzurrashid mentioned this pull request May 24, 2024
Merged
@tdbaine tdbaine mentioned this pull request May 24, 2024
Open
@arenault-pass arenault-pass mentioned this pull request May 24, 2024
Closed
@lryanle lryanle mentioned this pull request May 24, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Sep 3, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Sep 3, 2024
Open
@lryanle lryanle mentioned this pull request Sep 3, 2024
Open
@lydmoon lydmoon mentioned this pull request Sep 3, 2024
Open
@mkusztal mkusztal mentioned this pull request Sep 3, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Sep 4, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 6, 2024
Closed
This was referenced Sep 6, 2024
Merged
Merged
This was referenced Sep 7, 2024
Closed
Closed
@snyk-io snyk-io bot mentioned this pull request Sep 16, 2024
Open
@sunil-lakshman sunil-lakshman mentioned this pull request Sep 18, 2024
Closed
This was referenced Sep 24, 2024
Closed
Closed
Closed
Closed
@akanchhaS akanchhaS mentioned this pull request Sep 27, 2024
Open
@MohammadGhajari MohammadGhajari mentioned this pull request Sep 27, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Sep 28, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Sep 28, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 28, 2024
Closed
@lydmoon lydmoon mentioned this pull request Sep 28, 2024
Open
@lryanle lryanle mentioned this pull request Sep 28, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Sep 28, 2024
Open
@sunil-lakshman sunil-lakshman mentioned this pull request Sep 28, 2024
Closed
@mkusztal mkusztal mentioned this pull request Sep 29, 2024
Open
This was referenced Oct 1, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W-A-James W-A-James W-A-James approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@W-A-James W-A-James

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baileympearson @nbbeeken @W-A-James