feat(NODE-5186)!: remove duplicate BulkWriteResult accessors #3766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview of what defaultValue looks like |
W-A-James
added
the
Primary Review
W-A-James
previously approved these changes
Jul 10, 2023
W-A-James
added
Team Review
baileympearson
approved these changes
Jul 11, 2023
W-A-James
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
bypassDocumentValidationoption.Is there new documentation needed for these changes?
API docs will update in next release
What is the motivation for this change?
Removal of duplicate APIs so there is a single source of truth.
Release Highlight
BulkWriteResultdeprecated properties removedThe following deprecated properties have been removed as they duplicated the functionality provided by the common driver spec compliant properties. The list indicates what properties provide the correct migration:
BulkWriteResult.nInserted->BulkWriteResult.insertedCountBulkWriteResult.nUpserted->BulkWriteResult.upsertedCountBulkWriteResult.nMatched->BulkWriteResult.matchedCountBulkWriteResult.nModified->BulkWriteResult.modifiedCountBulkWriteResult.nRemoved->BulkWriteResult.deletedCountBulkWriteResult.getUpsertedIds->BulkWriteResult.upsertedIds/BulkWriteResult.getUpsertedIdAt(index: number)BulkWriteResult.getInsertedIds->BulkWriteResult.insertedIdsDouble check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript