feat: Add MongoOptions interface #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbroadst
reviewed
Nov 12, 2020
emadum
approved these changes
Nov 13, 2020
nbbeeken
force-pushed
the
NODE-2698/MongoOptions
branch
2 times, most recently
from
ba4fe1f to
e61706c
Compare
Adds MongoOptions representing the internal view of the specified options. NODE-2698
nbbeeken
force-pushed
the
NODE-2698/MongoOptions
branch
from
e61706c to
956b500
Compare
mbroadst
approved these changes
Nov 19, 2020
| /** | ||
| * Turn these options into a reusable connection URI | ||
| */ | ||
| toURI(): string; |
There was a problem hiding this comment.
Suggested change
| toURI(): string; | |
| toConnectionString(): string; |
just a thought? I'm the one that introduced calling it a URI, but I think the consensus across the drivers and the company is calling it a connection string
There was a problem hiding this comment.
Connection String URI Format
It's one of those both ways is right, I'll leave it as is, and we can consider renaming it when we get to the ticket that implements it since there might be some questions about how we want to expose it. These options are supposed to be internal, kind of, so is it something we'd want people to use: client.options.toURI() or would we surface something on the client itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds MongoOptions representing the internal view of the specified options.
NODE-2698
A number of options are seemingly omitted but instead are brought in by extending NodeJS's connection options. Particularly with tls options we have a number of translations from ssl to tls options and then another set of translations to NodeJS's equivalent definition. I've left documentation of the equivalent names and they will be resolved by the following work.