feat(NODE-4961)!: remove command result from commit and abort transaction APIs

[nbbeeken]

Description

What is changing?

• commit & abort transaction properly return void
• added a regression test

Is there new documentation needed for these changes?

The typescript has been updated.

What is the motivation for this change?

See notes

Release Highlight

session.commitTransaction() and session.abortTransaction() return void

Each of these methods erroneously returned server command results that can be different depending on server version or type the driver is connected to. These methods return a promise that if resolved means the command (aborting or commiting) sucessfully completed and rejects otherwise. Viewing command responses is possible through the command monitoring APIs on the MongoClient.

Double check the following

• Ran npm run check:lint script
• Self-review completed using the steps outlined here
• PR title follows the correct format: type(NODE-xxxx)[!]: description
  • Example: feat(NODE-1234)!: rewriting everything in coffeescript
• Changes are covered by tests
• New TODOs have a related JIRA ticket

[nbbeeken]

Needs test fixes from #3783, Otherwise ready for review.

[nbbeeken]

I put fixes to the tests in this PR, they assert void return values for withTransaction which will change to the value of the result of the executor in the other PR. Which ever lands first can easily merge and use the correct assertions.

[baileympearson]

There's a testing note in the ticket:

• Regression test

Do we have any tests that confirm these APIs return void (type or integration)?