Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-5415)!: bump minimum Node.js version to v16.20.1 #3760

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Jul 7, 2023

Description

What is changing?

  • Dropping testing & support for Node.js 14
  • Update engine field to >=16.20.1
  • Update tsconfig target & lib to es2021
Is there new documentation needed for these changes?

Update to the compat table will follow the release of v6

What is the motivation for this change?

Removing support for EOL node versions helps us keep our tooling and testing up to date and modern.

Release Highlight

Minimum Node.js version is now v16.20.1

The minimum supported Node.js version is now v16.20.1. We strive to keep our minimum supported Node.js version in sync with the runtime's release cadence to keep up with the latest security updates and modern language features.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken changed the title feat(NODE-5415)!: support only node.js 16 or above feat(NODE-5415)!: support only Node.js 16 or above Jul 7, 2023
@nbbeeken nbbeeken changed the title feat(NODE-5415)!: support only Node.js 16 or above feat(NODE-5415)!: bump minimum Node.js version to 16 or above Jul 7, 2023
@nbbeeken nbbeeken changed the title feat(NODE-5415)!: bump minimum Node.js version to 16 or above feat(NODE-5415)!: bump minimum Node.js version to v16.20.1 Jul 7, 2023
@nbbeeken nbbeeken marked this pull request as ready for review July 7, 2023 17:57
@baileympearson baileympearson self-assigned this Jul 7, 2023
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 7, 2023
@@ -16,28 +16,24 @@ describe('Error (Integration)', function () {
message: 'message 1, message 2'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch with the file name 😅

@baileympearson baileympearson added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jul 7, 2023
@baileympearson baileympearson merged commit de158b2 into main Jul 7, 2023
@baileympearson baileympearson deleted the NODE-5415-node16 branch July 7, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants