Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-3199): unable to bundle driver due to uncaught require #2903

Merged
merged 2 commits into from
Jul 20, 2021
Merged

fix(NODE-3199): unable to bundle driver due to uncaught require #2903

merged 2 commits into from
Jul 20, 2021

Conversation

nbbeeken
Copy link
Contributor

Tested locally webpack only returns warnings with this change

@nbbeeken nbbeeken mentioned this pull request Jul 14, 2021
Merged
emadum
emadum approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think we discussed adding comments to any requires in try/catch blocks to note the necessity of it for bundling, should we do that in this PR?

@nbbeeken
Copy link
Contributor Author

Oh yes, thanks for the reminder I'll do that now, plus gotta do this rebase

@nbbeeken nbbeeken force-pushed the NODE-3199/trycatch-deps branch from f835f84 to 02bae84 Compare July 16, 2021 19:29
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 19, 2021
@emadum emadum added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jul 19, 2021
@emadum emadum requested review from dariakp and durran July 19, 2021 16:17
dariakp
dariakp approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emadum emadum merged commit 60efe9d into 3.6 Jul 20, 2021
@emadum emadum deleted the NODE-3199/trycatch-deps branch July 20, 2021 16:35
@dariakp dariakp mentioned this pull request Aug 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp approved these changes

@emadum emadum emadum approved these changes

@durran durran Awaiting requested review from durran

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbbeeken @emadum @dariakp