Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(mongo-client): the new method MongoClient().connect() was wrongly… #1633

Merged
merged 2 commits into from
Jan 26, 2018
Merged

docs(mongo-client): the new method MongoClient().connect() was wrongly… #1633

merged 2 commits into from
Jan 26, 2018

Conversation

krufab
Copy link
Contributor

@krufab krufab commented Jan 16, 2018

… marked as deprecated instead of the old static MongoClient.connect()

… marked as deprecated instead of the old static MongoClient.connet()
@krufab krufab changed the title doc(mongo-client): the new method MongoClient().connect() was wrongly… docs(mongo-client): the new method MongoClient().connect() was wrongly… Jan 17, 2018
@krufab
Copy link
Contributor Author

krufab commented Jan 24, 2018

Hello @jlord,
would it be possible to review this PR? Or how's the procedure?
Thanks

Copy link
Contributor

@jlord jlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!
We think it would be ok for people to use the old way of connecting so if you can take out the deprecated change the other changes look good 👍

@krufab
Copy link
Contributor Author

krufab commented Jan 26, 2018

Ok, I've updated the code

@jlord
Copy link
Contributor

jlord commented Jan 26, 2018

Thanks so much @krufab! ✨

@jlord jlord merged commit a34512b into mongodb:3.0.0 Jan 26, 2018
@Jeff-Lewis
Copy link

This one threw me off. Can we update latest publsihed API docs?

@Leibosite
Copy link

also wrong in version 3.0.7,please check!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants