PYTHON-4299 Add support for TopologyDescriptionChangedEvent to expectEvents #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ShaneHarvey Please don't merge this until I've had a chance to look at it and ask questions. |
ShaneHarvey
commented
Apr 10, 2024
| else: | ||
| self.test.assertIsNone(actual.server_connection_id) | ||
| field = camel_to_snake(field) | ||
| self.test.assertEqual(getattr(actual, field), expected) |
There was a problem hiding this comment.
I refactored this code because the old version silently ignored any unknown fields. The new version fails on unknown fields so that we know to add support for them. It also should be easier to maintain since fields that only need to be renamed with camel_to_snake are supported automatically like "minWireVersion", "topologyVersion", "commandName", etc....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PYTHON-4299
POC for mongodb/specifications#1556