Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AWS SDK v2/v1 if available for AWS credential fetching #1017

Merged
merged 5 commits into from
Oct 19, 2022
Merged

Use AWS SDK v2/v1 if available for AWS credential fetching #1017

merged 5 commits into from
Oct 19, 2022
+301 −47

Conversation

jyemin
Copy link
Collaborator

@jyemin jyemin commented Oct 17, 2022 •
edited
Loading

To fetch AWS credentials from the environment:

  • Use AWS SDK v2 if available on the classpath
  • Otherwise, use AWS SDK v2 if available on the classpath
  • Otherwise, use the existing driver implementation

JAVA-4718

@jyemin
Use AWS SDK v2 if available for AWS credential fetching
bafd510 
To fetch AWS credentials from the environment:

  * Use AWS SDK v2 if available on the classpath
  * Otherwise, use the existing driver implementation

JAVA-4718
@jyemin jyemin self-assigned this Oct 17, 2022
@jyemin jyemin requested review from rozza and blink1073 October 17, 2022 18:14
blink1073
blink1073 approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rozza
rozza requested changes Oct 18, 2022
View reviewed changes
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit - then LGTM

@jyemin jyemin requested review from rozza and blink1073 October 18, 2022 20:01
@jyemin
Copy link
Collaborator Author

jyemin commented Oct 18, 2022

I added two more features:

  1. Support for AWS SDK v1 (requested by a user of Amazon Glue, where only v1 is provided)
  2. Support for testing all configurations in ECS (required a different way of specifying the three configurations

Boy, there are a ton of tasks now. We should consider a different way of doing this in Evergreen.

rozza
rozza reviewed Oct 19, 2022
View reviewed changes
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - not sure how to reduce the evergreen load.

Have a couple of questions for consideration

@jyemin jyemin requested a review from rozza October 19, 2022 12:10
rozza
rozza approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - happy either way for the v1 dependency to be in the pom

@jyemin jyemin changed the title Use AWS SDK v2 if available for AWS credential fetching Use AWS SDK v2/v1 if available for AWS credential fetching Oct 19, 2022
@jyemin jyemin merged commit 7b1904d into mongodb:master Oct 19, 2022
@jyemin jyemin deleted the j4718 branch October 19, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

@rozza rozza rozza approved these changes

Assignees

@jyemin jyemin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jyemin @rozza @blink1073