Add missing condition for whether to sleep in server monitor #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a missing check in an already-complicated conditinal statement for whether to sleep in the server monitor before executing the next check. The condition is included in the server discovery and monitoring specification pseudo-code but missing in the driver, and there are currently no tests for it. This commits adds the missing condition to the conditional statement. Effectively, this will reduce the number of sockets that the monitor opens on a server that is in the process of shutting down but still accepting connections. JAVA-4730
patrickfreed
approved these changes
Sep 29, 2022
There was a problem hiding this comment.
Code change LGTM. I'm not sure how to verify it though (is there an easy way to specify a git branch as a maven dependency?)
Also, it could be good to add a test for this behavior. It could do something like enable a failpoint on hello that returns ShutdownInProgress and verifies that the number of heartbeatFailed events is only 1 per heartbeatFrequencyMS. It may make sense to file a DRIVERS ticket for such a test.
|
I verified it by manually running your reproduction against this branch. DRIVERS ticket is a great idea. Would you mind opening? I think it's ok to commit this before having a regression test. I don't think it can be worse. |
|
Sounds good, filed DRIVERS-2458. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a missing check in an already-complicated conditinal statement for whether to sleep in the server monitor before executing the next check.
The condition is included in the server discovery and monitoring specification pseudo-code but missing in the driver, and there are currently no tests for it.
This commits adds the missing condition to the conditional statement. Effectively, this will reduce the number of sockets that the monitor opens on a server that is in the process of shutting down but still accepting connections.
JAVA-4730