Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-5224): deprecate UUID hex string cache control #573

Merged
merged 13 commits into from
Apr 24, 2023
Merged

feat(NODE-5224): deprecate UUID hex string cache control #573

merged 13 commits into from
Apr 24, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Apr 24, 2023 •
edited
Loading

Description

What is changing?

Deprecation from #572

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

Base automatically changed from NODE-4960-uuid-validation to main April 24, 2023 17:44
baileympearson
baileympearson requested changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs rebase?

@baileympearson baileympearson self-assigned this Apr 24, 2023
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 24, 2023
@nbbeeken nbbeeken requested a review from baileympearson April 24, 2023 17:46
@baileympearson baileympearson merged commit 70aea75 into main Apr 24, 2023
@baileympearson baileympearson deleted the NODE-5224-deprecate-uuid-hex-cache branch April 24, 2023 18:00
@github-actions github-actions bot mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@baileympearson baileympearson Awaiting requested review from baileympearson

Assignees

@baileympearson baileympearson

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbbeeken @addaleax @baileympearson