Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-4713)!: modernize bundling #534

Merged
merged 6 commits into from
Dec 16, 2022
Merged

feat(NODE-4713)!: modernize bundling #534

merged 6 commits into from
Dec 16, 2022

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Dec 5, 2022 •
edited
Loading

Description

What is changing?

Consolidating bundles and adding a rollup plugin to support mjs in the browser and node

What is the motivation for this change?

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken changed the title NODE-4713-bundling [WIP] feat!(NODE-4713): modernize bundling Dec 5, 2022
@nbbeeken nbbeeken changed the title [WIP] feat!(NODE-4713): modernize bundling [WIP] feat(NODE-4713)!: modernize bundling Dec 9, 2022
@nbbeeken nbbeeken force-pushed the NODE-4713-bundling branch 4 times, most recently from cb46283 to 836ff1c Compare December 12, 2022 20:17
@nbbeeken nbbeeken changed the title [WIP] feat(NODE-4713)!: modernize bundling feat(NODE-4713)!: modernize bundling Dec 12, 2022
nbbeeken
nbbeeken commented Dec 12, 2022
View reviewed changes
test/register-bson.js Outdated Show resolved Hide resolved
test/register-bson.d.ts Show resolved Hide resolved
src/extended_json.ts Show resolved Hide resolved
src/bson.ts Show resolved Hide resolved
.mocharc.json Show resolved Hide resolved
@nbbeeken nbbeeken marked this pull request as ready for review December 12, 2022 20:34
nbbeeken
nbbeeken commented Dec 12, 2022
View reviewed changes
package.json Show resolved Hide resolved
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Dec 13, 2022
@nbbeeken nbbeeken requested review from durran and addaleax December 13, 2022 17:54
durran
durran requested changes Dec 13, 2022
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of high level notes.

src/utils/node_byte_utils.ts Outdated Show resolved Hide resolved
test/load_bson.js Outdated Show resolved Hide resolved
@nbbeeken nbbeeken requested a review from durran December 13, 2022 20:40
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Dec 14, 2022
@durran durran merged commit 28ce4d5 into main Dec 16, 2022
@durran durran deleted the NODE-4713-bundling branch December 16, 2022 17:12
@nbbeeken nbbeeken mentioned this pull request Dec 19, 2022
Merged
5 tasks
@github-actions github-actions bot mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KuSh KuSh KuSh left review comments

@durran durran durran approved these changes

@addaleax addaleax Awaiting requested review from addaleax

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbbeeken @durran @KuSh