fix(NODE-3640): Fix Int32 constructor to coerce its argument to int32 #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjchong25
changed the title
dariakp
requested changes
Oct 22, 2021
dariakp
added
the
Primary Review
dariakp
requested changes
Oct 22, 2021
dariakp
removed
the
Primary Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Int32 constructor truncates its argument immediately to int32 so that out of bound values are dealt with properly. Tests for the max/min bounds as well as out of bound positive/negative values are added, existing tests that did not take into account this new functionality were updated.