fix: make inspect for ObjectId work #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous `Object.defineProperty()` calls did not work because they did not specify a property descriptor, and even if they had worked, the signatures of `.inspect()` and `.toString()` would have mismatched, and even if they weren’t, the result would not have been very useful as debugging output, because it only returned the raw hex content of the `ObjectId` and not even e.g. the fact that this object is an `ObjectId`. I’m happy with any other solution, but this particular one would make my life a tiny bit easier :)
mbroadst
approved these changes
Nov 12, 2020
|
@addaleax thanks! Yes, can you please open a JIRA ticket a well? That will help us make better release notes |
|
@mbroadst Neal already did that for me :) https://jira.mongodb.org/browse/NODE-2875 I wasn’t sure whether that was necessary/helpful but I’ll open tickets for everything in the future 👍 |
|
@mbroadst Not sure if your re-approval is a hint for me to merge this, because if so, I have to tell you that I can’t :) |
|
@addaleax thanks for the bump. I actually want to make sure we have at least two approvals from the team before changes are merged, we'll take care of merging for you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous
Object.defineProperty()calls did not work becausethey did not specify a property descriptor, and even if they had
worked, the signatures of
.inspect()and.toString()wouldhave mismatched, and even if they weren’t, the result would not
have been very useful as debugging output, because it only returned
the raw hex content of the
ObjectIdand not even e.g. the factthat this object is an
ObjectId.I’m happy with any other solution, but this particular one would
make my life a tiny bit easier :)
Description
Make the
inspectand[util.inspect.custom]methods onObjectIdwork.Not sure if I should open a JIRA ticket for this, but happy to do so if it helps :)