fix(retryableWrites): only remove primary after retry (#274)

Make sure to not remove the primary on an error until after the retry
mongodb-js · Feb 2, 2018 · 7ac171e · 7ac171e
1 parent 8c4a0ef
commit 7ac171e
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/topologies/replset.js b/lib/topologies/replset.js
@@ -1212,14 +1212,14 @@ function executeWriteOperation(args, options, callback) {
       return callback(err);
     }
 
-    // Per SDAM, remove primary from replicaset
-    self.s.replicaSetState.remove(self.s.replicaSetState.primary, { force: true });
-
     if (willRetryWrite) {
       const newArgs = Object.assign({}, args, { retrying: true });
       return executeWriteOperation(newArgs, options, callback);
     }
 
+    // Per SDAM, remove primary from replicaset
+    self.s.replicaSetState.remove(self.s.replicaSetState.primary, { force: true });
+
     return callback(err);
   };