fix(connection): make pool not try to reconnect forever when reconnec…

…tTries = 0 (#275)

* fix(connection): make pool not try to reconnect forever when reconnectTries = 0

* test(server): add test coverage for #275

Re: Automattic/mongoose#6028

lib/connection/pool.js

@@ -364,7 +364,7 @@ function attemptReconnect(self) {
         // Count down the number of reconnects
         self.retriesLeft = self.retriesLeft - 1;
         // How many retries are left
-        if (self.retriesLeft === 0) {
+        if (self.retriesLeft <= 0) {
           // Destroy the instance
           self.destroy();
           // Emit close event

test/tests/functional/server_tests.js

@@ -1077,4 +1077,27 @@ describe('Server tests', function() {
       }
     });
   });
+
+  it('Should not try to reconnect forever if reconnectTries = 0', {
+    metadata: { requires: { topology: 'single' } },
+
+    test: function(done) {
+      // Attempt to connect
+      let server = new Server({
+        host: 'doesntexist',
+        bson: new Bson(),
+        reconnectTries: 0
+      });
+
+      // Add event listeners
+      server.on('error', function() {});
+
+      // Start connection
+      server.connect();
+
+      server.s.pool.on('reconnectFailed', function() {
+        done();
+      });
+    }
+  });
 });