Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quits once it finishing handling squirrel flag #36

Open
trodi opened this issue Jan 18, 2019 · 0 comments
Open

Code quits once it finishing handling squirrel flag #36

trodi opened this issue Jan 18, 2019 · 0 comments

Comments

@trodi
Copy link

trodi commented Jan 18, 2019

The usage documentation shows calling app.quit() after requireing electron-squirrel-startup, however, the code calls quit itself. This is misleading. If you run your own code on one of these flags after requireing electron-squirrel-startup, the app will quit from under you. The documentation should match the code. It would be nice to only optionally quit or not quit at all for flexibility.

Usage Docs

if(require('electron-squirrel-startup')) app.quit();

Source Code

run(['--createShortcut=' + target + ''], app.quit);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant