Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where is RPC "/get_random_outs"? #4450

Closed
moneroexamples opened this issue Sep 26, 2018 · 9 comments
Closed

Where is RPC "/get_random_outs"? #4450

moneroexamples opened this issue Sep 26, 2018 · 9 comments

Comments

@moneroexamples
Copy link
Contributor

There is still code in the wallet that depends on this call, e.g. wallet2::light_wallet_get_outs https://github.com/monero-project/monero/blob/master/src/wallet/wallet2.cpp#L6332

/get_random_outs seems to be totally gone, but the code that uses it is still in the wallet. Was it deprecated? If so, maybe to code that depends on it also should be removed or modified?

Similarly, struct COMMAND_RPC_GET_RANDOM_OUTS is still present, even though its only used wallet2::light_wallet_get_outs which is not going to work anyway at present.

@moneromooo-monero
Copy link
Collaborator

It's gone. vtnerd said he'd have the light wallet server updated soon.

@moneroexamples
Copy link
Contributor Author

Cool. Thanks for the info.

@dooglio
Copy link

dooglio commented Nov 4, 2018

Where is there information on the light wallet server? When will it be implemented?

Using the current version of the monero server, those RPC calls are gone. That means that you can't even use MyMonero to send anything, because RandomOuts() won't work against a full node:

https://github.com/mymonero/mymonero-app-js/blob/90e6fe965ccfd7097cdbf6eb0ed4d17a3204862e/local_modules/HostedMoneroAPIClient/HostedMoneroAPIClient_Base.js#L392

...unless I'm missing something?

@moneroexamples
Copy link
Contributor Author

MyMonero is running custom backend. So it does not matter much that get_random_outs is gone from offical monero sources, as all the information needed for MyMonero is provided by their own backend.

Opensourced MyMonero backend is being developed here: https://github.com/mymonero/hostedwallet-server-staging So you can have a look at its status there. Other link to monitor is here: #4139

@gutenye
Copy link

gutenye commented Nov 5, 2018

@moneroexamples What's the relationship between mymonero/hostedwallet-server-staging and moneroexamples/openmonero. I saw they both are open source implementation of MyMonero backend.

@dooglio
Copy link

dooglio commented Nov 5, 2018

@moneroexamples Sorry, I was under the impression that HostedMoneroAPIClient connected to a Monero full node, not a MyMonero server.

@moneroexamples
Copy link
Contributor Author

@gutenye

mymonero/hostedwallet-server-staging is being developed by mymonero team. openmonero is an independent effort.

@gutenye
Copy link

gutenye commented Nov 8, 2018

@vtnerd any updates on the light wallet server?
Without /get_random_outs call, how can a light wallet create a transaction at the moment?

@vtnerd
Copy link
Contributor

vtnerd commented Nov 8, 2018

Without /get_random_outs call, how can a light wallet create a transaction at the moment?

It cannot create a transaction without this endpoint working.

@vtnerd any updates on the light wallet server?

Locally I have updated the light wallet server to do random output selection with the latest algorithm ( even the window selection change in review)! Unfortunately, it cannot duplicate exactly what wallet2 is doing until the REST-API is changed to send the "real" index (for fork selection + privacy-to-monerod). I still need to verify the gamma distribution selection - it appeared to be clustering in an unexpecting way at first glance.

Before posting I'm likely to make one last DB change - check the main PR which will receive a force push of the "squashed" changeset.

EDIT: After this last DB change I expect the DB to be "stable" - any future DB changes should come with migration code like monerod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants