-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Where is RPC "/get_random_outs"? #4450
Comments
It's gone. vtnerd said he'd have the light wallet server updated soon. |
Cool. Thanks for the info. |
Where is there information on the light wallet server? When will it be implemented? Using the current version of the monero server, those RPC calls are gone. That means that you can't even use MyMonero to send anything, because ...unless I'm missing something? |
MyMonero is running custom backend. So it does not matter much that Opensourced MyMonero backend is being developed here: https://github.com/mymonero/hostedwallet-server-staging So you can have a look at its status there. Other link to monitor is here: #4139 |
@moneroexamples What's the relationship between |
@moneroexamples Sorry, I was under the impression that |
|
@vtnerd any updates on the light wallet server? |
It cannot create a transaction without this endpoint working.
Locally I have updated the light wallet server to do random output selection with the latest algorithm ( even the window selection change in review)! Unfortunately, it cannot duplicate exactly what wallet2 is doing until the REST-API is changed to send the "real" index (for fork selection + privacy-to- Before posting I'm likely to make one last DB change - check the main PR which will receive a force push of the "squashed" changeset. EDIT: After this last DB change I expect the DB to be "stable" - any future DB changes should come with migration code like |
There is still code in the wallet that depends on this call, e.g.
wallet2::light_wallet_get_outs
https://github.com/monero-project/monero/blob/master/src/wallet/wallet2.cpp#L6332/get_random_outs
seems to be totally gone, but the code that uses it is still in the wallet. Was it deprecated? If so, maybe to code that depends on it also should be removed or modified?Similarly,
struct COMMAND_RPC_GET_RANDOM_OUTS
is still present, even though its only usedwallet2::light_wallet_get_outs
which is not going to work anyway at present.The text was updated successfully, but these errors were encountered: