Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic: runtime error: during discovery (rate limiting issue?) #5133

Open
mm-weber opened this issue Jan 29, 2025 · 6 comments · May be fixed by #5149
Open

panic: runtime error: during discovery (rate limiting issue?) #5133

mm-weber opened this issue Jan 29, 2025 · 6 comments · May be fixed by #5149
Assignees
Labels
bug Something isn't working gcp

Comments

@mm-weber
Copy link
Contributor

Describe the bug
When creating a new GCP cluster:

Image

This will break the discovery when trying to connect via this:

cnspec shell gcp project <project-name> --discover gke-clusters

Image

To Reproduce
Steps to reproduce the behavior:

  1. Create a new GKE cluster from the console
  2. Run cnspec shell gcp project <project-name> --discover gke-clusters
  3. Note the error

Expected behavior
The discovery should not fail when a GKE cluster is being created.

Screenshots or CLI Output
See above

Desktop (please complete the following information):

installing provider 'gcp' version=11.0.63

Additional context
Add any other context about the problem here.

@mm-weber mm-weber added bug Something isn't working gcp labels Jan 29, 2025
@mm-weber mm-weber changed the title panic: runtime error: during discovery when GCP cluster is being created panic: runtime error: during discovery when more than one GKE cluster exists Jan 29, 2025
@mm-weber
Copy link
Contributor Author

mm-weber commented Jan 29, 2025

Update

This issue happens when the number of GKE clusters in a project exceeds 1 !
Just tried after the provisioning was complete, the error persisted.

@mm-weber
Copy link
Contributor Author

Update 2:

Even after deleting one of the two testing clusters, the error seems to persist when trying to discover the cluster left behind.
Could this be a rate-limiting issue?

@mm-weber mm-weber changed the title panic: runtime error: during discovery when more than one GKE cluster exists panic: runtime error: during discovery (rate limiting issue?) Jan 29, 2025
@vjeffrey
Copy link
Contributor

two problems here:
need to fix threads per core, we're trying to give it a bool right now, it should be:
+ "threadsPerCore": llx.IntDataPtr(cfg.AdvancedMachineFeatures.ThreadsPerCore),

the serviceaccount init from the gke cluster is failing to trigger

@vjeffrey
Copy link
Contributor

the first bit is an easy fix but i am struggling to figure out why on earth the service account init is not triggering, will continue to look

@vjeffrey
Copy link
Contributor

partially resolved with #5135

@vjeffrey vjeffrey self-assigned this Jan 29, 2025
@vjeffrey
Copy link
Contributor

ok, got it all working with https://github.com/mondoohq/cnquery/compare/vj/fixgke-2?expand=1

feels like im overcomplicating the second commit so ill get back to that tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gcp
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants