From ff88599031da8ea25d5e4717c201f147042ac645 Mon Sep 17 00:00:00 2001
From: Mikita Iwanowski <info@slnt-opp.xyz>
Date: Thu, 22 Aug 2024 13:27:51 +0200
Subject: [PATCH] =?UTF-8?q?=F0=9F=A7=B9=20token=20validation=20errors=20ha?=
 =?UTF-8?q?ndling=20(#4579)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* token validation errors handling

Resolves #4550

* Update apps/cnquery/cmd/login.go

Co-authored-by: Tim Smith <tsmith84@gmail.com>

* print warnings from API health

---------

Co-authored-by: Tim Smith <tsmith84@gmail.com>
---
 apps/cnquery/cmd/login.go | 51 ++++++++++++++++++++++++++++++++++++---
 1 file changed, 47 insertions(+), 4 deletions(-)

diff --git a/apps/cnquery/cmd/login.go b/apps/cnquery/cmd/login.go
index 031c92a85..f3726bed8 100644
--- a/apps/cnquery/cmd/login.go
+++ b/apps/cnquery/cmd/login.go
@@ -19,6 +19,7 @@ import (
 	cnquery_providers "go.mondoo.com/cnquery/v11/providers"
 	"go.mondoo.com/cnquery/v11/providers-sdk/v1/sysinfo"
 	"go.mondoo.com/cnquery/v11/providers-sdk/v1/upstream"
+	"go.mondoo.com/cnquery/v11/providers-sdk/v1/upstream/health"
 	rangerUtils "go.mondoo.com/cnquery/v11/utils/ranger"
 	"go.mondoo.com/ranger-rpc"
 	"go.mondoo.com/ranger-rpc/codes"
@@ -26,6 +27,11 @@ import (
 	"go.mondoo.com/ranger-rpc/status"
 )
 
+var (
+	tokenValidationErr = errors.New("The token is not a valid token to register this client with Mondoo Platform")
+	tokenExpiredErr    = errors.New("The token is expired")
+)
+
 func init() {
 	rootCmd.AddCommand(LoginCmd)
 	LoginCmd.Flags().StringP("token", "t", "", "Set a client registration token")
@@ -63,13 +69,42 @@ You remain logged in until you explicitly log out using the 'logout' subcommand.
 		apiEndpointOverride, _ := cmd.Flags().GetString("api-endpoint")
 		err := register(token, annotations, timer, splay, apiEndpointOverride)
 		if err != nil {
+			if err == tokenValidationErr {
+				log.Error().Msg(err.Error())
+
+				// Prevents help message from being printed
+				return nil
+			}
 			defer func() {
-				s, err := checkStatus()
+				opts, optsErr := config.Read()
+				if optsErr != nil {
+					log.Error().Err(optsErr).Msg("could not load configuration")
+					return
+				}
+
+				httpClient, err := opts.GetHttpClient()
 				if err != nil {
-					log.Warn().Err(err).Msg("could not run status command")
+					log.Error().Err(optsErr).Msg("failed to set up Mondoo API client")
+					return
+				}
+
+				upstreamStatus, err := health.CheckApiHealth(httpClient, opts.UpstreamApiEndpoint())
+				if err != nil {
+					log.Error().Err(err).Msg("could not check upstream health")
+					return
+				}
+
+				for _, warn := range upstreamStatus.Warnings {
+					log.Warn().Msg(warn)
 				}
-				s.RenderCliStatus()
 			}()
+
+			if err == tokenExpiredErr {
+				log.Error().Msg(err.Error())
+
+				// Prevents help message from being printed
+				return nil
+			}
 		}
 		return err
 	},
@@ -105,15 +140,23 @@ func register(token string, annotations map[string]string, timer int, splay int,
 		claims, err := upstream.ExtractTokenClaims(token)
 		if err != nil {
 			log.Warn().Err(err).Msg("could not read the token")
+			return tokenValidationErr
 		} else {
 			if len(claims.Description) > 0 {
 				log.Info().Msg("token description: " + claims.Description)
 			}
 			if claims.IsExpired() {
-				log.Warn().Msg("token is expired")
+				return tokenExpiredErr
+			} else if claims.Expiry == nil {
+				log.Warn().Msg("token does not contain an expiry date")
 			} else {
 				log.Info().Msg("token will expire at " + claims.Claims.Expiry.Time().Format(time.RFC1123))
 			}
+			if claims.Space == "" {
+				log.Warn().
+					Msg("token does not contain a space")
+				return tokenValidationErr
+			}
 
 			// use the api endpoint from the token if not overridden via flag
 			if apiEndpointOverride == "" {