Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off comments by default #194

Closed
mondeja opened this issue Jan 29, 2024 · 0 comments · Fixed by #233
Closed

Turn off comments by default #194

mondeja opened this issue Jan 29, 2024 · 0 comments · Fixed by #233
Labels
breaking change Must be released in a new major version enhancement New feature or request
Milestone
v7.0.0

Comments

@mondeja
Copy link
Owner

mondeja commented Jan 29, 2024

There are some cases when including with comments enabled breaks the content. At least:

Might be worth to change the default value to false. I think that so much people doesn't even know that there are comments added by default and are not worth if they are breaking some includes.
@mondeja mondeja added the breaking change Must be released in a new major version label Jan 29, 2024
@mondeja mondeja changed the title Turn comments off by default? Turn comments off by default Jan 29, 2024
@mondeja mondeja added this to the v7.0.0 milestone Jan 29, 2024
@mondeja mondeja changed the title Turn comments off by default Turn off comments by default Jan 29, 2024
@mondeja mondeja added the good first issue Good for newcomers label Jun 3, 2024
@mondeja mondeja added chore enhancement New feature or request and removed good first issue Good for newcomers chore labels Oct 21, 2024
@mondeja mondeja mentioned this issue Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Must be released in a new major version enhancement New feature or request
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging a pull request may close this issue.

Set comments=false as default for include-markdown directive mondeja/mkdocs-include-markdown-plugin
1 participant
@mondeja