-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for pydantic 2 compatibility #189
Merged
caufieldjh
merged 7 commits into
main
from
188-typeerror-configuredbasemodel__init_subclass__-takes-no-keyword-arguments
Sep 1, 2023
Merged
Updates for pydantic 2 compatibility #189
caufieldjh
merged 7 commits into
main
from
188-typeerror-configuredbasemodel__init_subclass__-takes-no-keyword-arguments
Sep 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit tests are failing because they rely on pickled fixtures (ooh, that's a good tongue twister):
|
pkalita-lbl
approved these changes
Sep 1, 2023
caufieldjh
deleted the
188-typeerror-configuredbasemodel__init_subclass__-takes-no-keyword-arguments
branch
September 1, 2023 18:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Makefile to ensure that linkml's gen-pydantic produces pydantic 2 classes.
Pydantic imports elsewhere in the project have been updated accordingly.
This also involves skipping export tests and removing full exports from
make all
, as templates prepared with a Pydantic version differing from that expected by linkml (which is not specifically pinned to pydantic 2) will cause errors when exporting to OWL, RDF, etc. This isn't essential to core functionality of OntoGPT, though it's otherwise useful, so it will soon return.