Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAC address incorrect #5

Open
lprhodes opened this issue Apr 7, 2017 · 3 comments
Open

MAC address incorrect #5

lprhodes opened this issue Apr 7, 2017 · 3 comments

Comments

@lprhodes
Copy link

lprhodes commented Apr 7, 2017

Hey,

Just wondering why you commented out the hex reference on line 173 (which is the correct)

@momodalo
Copy link
Owner

momodalo commented Apr 7, 2017

I am an old school programmer, so prefer copy method more than assign :)

@momodalo momodalo closed this as completed Apr 7, 2017
@momodalo momodalo reopened this Apr 7, 2017
@momodalo
Copy link
Owner

momodalo commented Apr 7, 2017

wait...Do you think the address range is incorrect? I tested with hex dump and think this one is correct. May need to check again.

@lprhodes
Copy link
Author

lprhodes commented Apr 7, 2017

The original address range commented out on line 173 is correct though it returns in an odd order. The correct order is as follows:

msg.copy(mac, 0x00, 0x3D);
msg.copy(mac, 0x01, 0x3E);
msg.copy(mac, 0x02, 0x3F);
msg.copy(mac, 0x03, 0x3C);
msg.copy(mac, 0x04, 0x3B);
msg.copy(mac, 0x05, 0x3A);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants