Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update protos and add Makefile #111

Merged
merged 5 commits into from
Nov 25, 2024
Merged

fix: update protos and add Makefile #111

merged 5 commits into from
Nov 25, 2024

Conversation

anitarua
Copy link
Collaborator

@anitarua anitarua commented Nov 22, 2024

Working towards https://github.com/momentohq/dev-eco-issue-tracker/issues/1066

Had to update the protos in order to access topics sequence number. Fixed one import error as a result.

Added Makefile and updated contributing docs for convenience while here. Fixed some formatting/lint errors as a result.

@anitarua anitarua requested review from rishtigupta and a team November 22, 2024 22:01
Copy link
Contributor

@rishtigupta rishtigupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anitarua anitarua merged commit 40ddb24 into main Nov 25, 2024
2 checks passed
@anitarua anitarua deleted the update-protos branch November 25, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants