Question/change request: moment as a peer dependency

[seansfkelley]

In the past, moment was changed to be a peer dependency. This seems like the right thing to do for reasons outlined in tickets like #622.

It was then reverted with no explanation, perhaps in response to #622 (comment) (which observed that this would be a breaking change, and that's true, though moment-timezone is still 0.x.x so breaking changes are allowed at any time).

So the question/request is: can we make moment a peer dependency again, or, why was it reverted to no longer be a peer dependency?

My use-case: I also use moment-range, which, like moment-timezone, side-effect changes the moment. I want them to share an instance of moment, but as the dependencies are currently defined, I have to purposely not install moment and instead pull it through moment-timezone. This means moment-range complains about missing peer dependencies, even though there's not actually a problem.

cc @Americas who opened the original issue/PR to move it to a peer dependency.

[ichernev]

I'm all for this, it's a breaking change, but it's for the better, also moment-timezone is not stable as you pointed out (starting with zero), so I think it's fine :)

[gilmoreorless]

A breaking change proposal is open, which would include this change: #1039