-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change year range for data file to 2013-2023 #614
Comments
Hi @Schnark I have created a PR for this issue. But the build failed. Can someone please help me fix this build issue? |
Referencing #363 (comment) , would it be possible to rename the file to something like "moment-timezone-with-data-truncated.js" so that the path doesn't need to continually change? |
Thinking about this more, I believe the correct way to handle this is to do all of the following:
I'll pick this up for the next release, coming shortly. |
Actually, I see no reason to publish older year range files. We'll keep 2012-2022 intact, and add a 1970-2030 and a 5-year rolling file. |
This is completed in version 0.5.24. Thanks. |
@mj1856 how does one use the new smaller file (1970-2030)? |
@MatthewHerbst For example, in my project: import Moment from "moment";
import MomentTZ from "moment-timezone/builds/moment-timezone-with-data-10-year-range"; Basically, the build contains the moment-timezone library and the data for the date ranges, and can be substituted for the normal moment-timezone + data import. More information can be found in the documentation: http://momentjs.com/timezone/docs/ |
Thanks @andrewpanfelsherpa! |
Currently, there is a file
moment-timezone-with-data-2012-2022.js
for those who want a smaller data file with only currently relevant data. For 2018 this range should be changed to 2013-2023, as it is supposed to be "current year +/-5 years" (previous change on this was 83e81ef).The text was updated successfully, but these errors were encountered: