Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about adding much more test cases? #900

Closed
samchon opened this issue Jul 5, 2022 · 4 comments
Closed

What about adding much more test cases? #900

samchon opened this issue Jul 5, 2022 · 4 comments

Comments

@samchon
Copy link
Contributor

samchon commented Jul 5, 2022

https://github.com/samchon/typescript-json/tree/master/test/structures

I'm developing a runtime type checker (validator) library, and have prepared lots of test cases, for hardcore validation.

How about typescript-runtime-type-benchmarks to adapt such test cases?

They may be useful.

@samchon
Copy link
Contributor Author

samchon commented Jul 5, 2022

@moltar
Copy link
Owner

moltar commented Jul 7, 2022

I am open to having more tests, but we need to be mindful of total run time. If we have too many or too slow ones then it'll be taking a long time, and we can even eventually run out of CI time limit 😁

But having more different tests, I think is a good idea overall. Just need to understand what we are targeting and what are usually the slow parts.

@jviide
Copy link
Contributor

jviide commented Aug 5, 2022

Validation failures are also one less-benchmarked case. Their performance also becomes relevant in cases like union/oneOf/... where some subvalidators might fail while the whole validation succeeds as a whole.

@moltar moltar mentioned this issue Feb 6, 2023
@samchon
Copy link
Contributor Author

samchon commented Feb 8, 2023

Wrote another issue with a little bit different idea -> #1025

@samchon samchon closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants