Run & review this pull request in StackBlitz Codeflow.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (48b63a9) to head (97f556a).

@@            Coverage Diff            @@
##                v3      #497   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Hi @mitulagr2, thanks for taking the time to fix this. I’m currently working on an app that makes heavy use of URL search parameters to encode/share UI state, so I’m quite interested in better testing support for the useSearch hook.

I’ve tested your changes and noticed a few issues:

• The location hook includes the search string in the returned value. The default browser location hook returns the path only.
• The search hook returns a single-valued array, whereas the browser location search hook returns a string.

I’ve tried to fix these issues here: https://github.com/tillprochaska/wouter/tree/memory-location-search-hook

@molefrog I’ve seen that this PR has been open for quite a while. Is there anything else I could help with to move this forward?

I saw that the recent release includes a new useSearchParams hook. It would probably be nice if the memory location implementation had support for that as well, but that could probably be added separately on top of these changes.