Switch from triomphe::Arc to MiniArc, our own Arc implementation
#456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
==========================================
- Coverage 94.79% 94.73% -0.07%
==========================================
Files 44 45 +1
Lines 20306 20416 +110
==========================================
+ Hits 19249 19341 +92
- Misses 1057 1075 +18 |
`MiniArc` is like a `std::sync::Arc` but with a few differences: - No `Weak` references. - Uses `AtomicU32` instead of `AtomicUsize` for reference counting. - Much smaller code size by having only the necessary methods for us.
tatsuya6502
force-pushed
the
mini-arc
branch
from
e337163
to
2e463d3
Compare
…into `moka` Also enable Miri and Loom tests on the CI (GitHub Actions).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a crate private
MiniArctype, a minimal implementation of atomic reference counted shared pointer. It is like astd::sync::Arcandtriomphe::Arcbut with a few differences:Weakreferences, soMiniArcdoes not have the weak reference counter.AtomicU32instead ofAtomicUsizefor the strong reference counter.mokaandmini-moka.MiniArcreplaces alltriomphe::Arcusages inmoka.On the CI (GitHub Actions), the following tests are performed in addition to the regular tests:
MiniArc.MiniArc.Fixes #440