Uncaught TypeError: Cannot read property 'register' of undefined

[yulolimum]

I added torch to package.json and installed. It's loading the torch.js but erring on the pickaday import:

Using webpack.

It may be due to the fact that moment is an "optionalDependency".

[darinwilson]

This appears to be an issue with webpack configuration, as it doesn't happen with brunch. I'm putting this on hold for now, but will look into later as we'll be using torch on a webpack project, and I may learn more about this issue then.

[darinwilson]

After further research, it appears that brunch is ill-suited to create NPM packages:

brunch/brunch#713

Brunch has historically been meant for building web apps, not libs, so this hasn't been that important for the type of use-cases Brunch typically targets.

I think this explains why the package works fine in a brunch-managed project, but not a webpack-managed project.

If I'm reading the issue correctly, we'll need a different build process to create a fully NPM-compatible package for torch.

[danielberkompas]

@darinwilson Now that we have integrated Torch with CrossConnect, which uses webpack, did this actually end up being a problem?

[darinwilson]

@danielberkompas Sorry I didn't respond to this sooner. Yes, it's still a problem. I had to do some hacking to get it to work with CC. See the PR for torch integration

From what I could tell, it seems that creating an NPM package with brunch makes it incompatible with webpack. I'm not 100% sure about that, but other folks reported similar problems. At that point, it became to keep of a rabbit hole to pursue, so I just put some duct tape on the CC JS setup and moved on.

[zberkom]

@danielberkompas I think this may have been fixed by removing the umbrella application. Is that correct?

[zberkom]

I just tested this with the latest version of webpack and had no issues. I'm closing this issue for now & reopening an .npmignore issue, since the package in node_modules is currently including the entire git repo.