Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize MOJOs on SimpleDateFormat for timestampFormat #40

Closed
jgeorgeson opened this issue Jun 21, 2016 · 0 comments · Fixed by #86
Closed

Standardize MOJOs on SimpleDateFormat for timestampFormat #40

jgeorgeson opened this issue Jun 21, 2016 · 0 comments · Fixed by #86

Comments

@jgeorgeson
Copy link
Contributor

jgeorgeson commented Jun 21, 2016

I found it quite confusing to have a common parameter name shared between MOJOs being implemented in different ways. I prefer the SimpleDateFormat and you already have a utility class that can be called uniformly across MOJOs. I will be submitting a PR to accomplish the following:

  1. Update CreateMojo to use Utils.createTimestamp()
  2. Check for usage of java.text.MessageFormat value in timestampFormat and warn of it's deprecation while regex parsing out the format for backwards-compatibility
  3. Update all the IT projects except basic-it so that the warning and backwards-compatibility are validated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants