Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend FX Quotes to support Simple Routing = false #3885

Closed
8 of 19 tasks
PaulGregoryBaker opened this issue Apr 25, 2024 · 0 comments
Closed
8 of 19 tasks

Extend FX Quotes to support Simple Routing = false #3885

PaulGregoryBaker opened this issue Apr 25, 2024 · 0 comments
Assignees
Labels
core-dev-squad fx Label for FX issues story

Comments

@PaulGregoryBaker
Copy link

PaulGregoryBaker commented Apr 25, 2024

Goal:

As a Mojaloop Community member making use of FX conversion in mojaloop
I want to ensure that the FX implementation POC is matured
so that it can be merged into master and ultimately included in a release of mojaloop and used.

Note: This story covers the harnening of the central services components that are associated with the fx quotes.

  • The POC only catered for simple routing mode. This story needs to include the other routing mode.

Acceptance Criteria:

  • Verify that error cases are mapped and documented.
  • Verify that the integration test are added to test the error cases.
  • Verify that unit test are added
  • Verify that all mojaloop core standards are met

Note:
The current integration test harness is not great; May need to update with the integration framework that is running in Central Ledger

Complexity: <High|Medium|Low> > A short comment to remind the reason for the rating

Uncertainty: <High|Medium|Low> > A short comment to remind the reason for the rating


Tasks:

  • Prep database design
  • Add migrations to CL repository
  • Implement functionality
  • Add unit tests
  • Add integration tests

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • TBD

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@kleyow kleyow closed this as completed Aug 19, 2024
@kleyow kleyow self-assigned this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-dev-squad fx Label for FX issues story
Projects
None yet
Development

No branches or pull requests

2 participants