Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CENTRAL_LEDGER] Implement the Central Ledger batch-fufil flow for FX position handler #3821

Closed
10 of 22 tasks
PaulGregoryBaker opened this issue Mar 19, 2024 · 0 comments
Closed
10 of 22 tasks
Assignees

Comments

@PaulGregoryBaker
Copy link

PaulGregoryBaker commented Mar 19, 2024

Goal:

As a Mojaloop Community member making use of FX conversion in mojaloop
I want to ensure that the FX implementation POC is standardized
so that it can be merged into master and ultimately included in a release of mojaloop and used.

Note: This story was initially implemented in the non-batch as part of a POC. This functionality need to be re-implemented in the performant position batch handler, and then needs to be hardened with full testing so that it can be merged into master.

The followin components need to be addressed in this story.

  • batch position commit handler (need to be implemented) (This is similar to the code added to the non-batch position commit handler added in the POC).
    (This excludes timeouts and aborts, as they are captured in another story.)

Acceptance Criteria:

  • Verify that error cases are mapped and documented.
  • Verify that the integration test are added to test the error cases.
  • Verify that unit test are added
  • Verify that all mojaloop core standards are met

Complexity: <High|Medium|Low> > A short comment to remind the reason for the rating

Uncertainty: <High|Medium|Low> > A short comment to remind the reason for the rating


Tasks:

  • Migrate position fulfil logic to batch handler [@vijayg10 ]
  • Add unit tests [@vijayg10 ]
  • Refactor existing fulfil batch handler to support FX [@vijayg10 ]
  • Adjust unit tests for the changes [@vijayg10 ]
  • Add integration tests
  • Make sure functional tests are working [@kleyow]

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • TBD

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@PaulGregoryBaker PaulGregoryBaker added core-dev-squad story to-be-refined This story is ready to be groomed fx Label for FX issues PI-23 and removed to-be-refined This story is ready to be groomed labels Mar 19, 2024
@PaulGregoryBaker PaulGregoryBaker changed the title [CENTRAL_LEDGER] Harden the Central Ledger-fufil flow for FX [CENTRAL_LEDGER] Implement the Central Ledger batch-fufil flow for FX position handler Apr 8, 2024
@chris-me-law chris-me-law changed the title [CENTRAL_LEDGER] Implement the Central Ledger batch-fufil flow for FX position handler [CENTRAL_LEDGER] Implement the Central Ledger batch-fufil flow for FX position handler (Edit) Apr 22, 2024
@chris-me-law chris-me-law changed the title [CENTRAL_LEDGER] Implement the Central Ledger batch-fufil flow for FX position handler (Edit) [CENTRAL_LEDGER] Implement the Central Ledger batch-fufil flow for FX position handler Apr 22, 2024
@chris-me-law chris-me-law assigned vijayg10 and unassigned vijayg10 Apr 22, 2024
@vijayg10 vijayg10 self-assigned this Apr 23, 2024
@JaneS321 JaneS321 added the Pi-24 label May 2, 2024
@kleyow kleyow self-assigned this May 3, 2024
@kleyow kleyow closed this as completed May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants