Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FX Quotes POC #3689

Closed
24 of 25 tasks
PaulGregoryBaker opened this issue Dec 12, 2023 · 3 comments
Closed
24 of 25 tasks

Implement FX Quotes POC #3689

PaulGregoryBaker opened this issue Dec 12, 2023 · 3 comments
Assignees
Labels
core-dev-squad oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it PI-23 story

Comments

@PaulGregoryBaker
Copy link

PaulGregoryBaker commented Dec 12, 2023

Goal:

As a Mojaloop Community member interested in implementing FX
I want to build a POC to implement the FXQuote
so that I can prove that the FX flows work

Assumption: SIMPLE ROUTING MODE is enabled for this PoC (We don't need to create database tables and store the fxquotes)

Reference documents:

Note

  • Implementation should be merged into a feature branch (feature/fx-impl) and not the main branch

Acceptance Criteria:

  • Verify that the FXquote endpoint is handled in the hub to route message to FX providers
  • Verify that the API resource complies with FSPIOP 2.0 definitions
  • Verify a happy path functional test is in place to test the new functionality

Complexity: <High|Medium|Low> > A short comment to remind the reason for the rating

Uncertainty: <High|Medium|Low> > A short comment to remind the reason for the rating


Tasks:

  • Implement POST /fxQuotes endpoint
  • Implement GET /fxQuotes/{ID} endpoint
  • Implement PUT /fxQuotes/{ID} endpoint
  • Implement PUT /fxQuotes/{ID}/error endpoint
  • Implement POST /fxQuotes handler
  • Implement GET /fxQuotes/{ID} handler
  • Implement PUT /fxQuotes/{ID} handler
  • Implement PUT /fxQuotes/{ID}/error handler
  • Add functional tests

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@JaneS321
Copy link

Hey team! Please add your planning poker estimate with Zenhub @kleyow @mdebarros @sri-miriyala @vijayg10

@JaneS321
Copy link

Please add your planning poker estimate with Zenhub @oderayi

@JaneS321
Copy link

Please add your planning poker estimate with Zenhub @aaronreynoza

@JaneS321 JaneS321 removed the to-be-refined This story is ready to be groomed label Feb 26, 2024
@oderayi oderayi self-assigned this Feb 27, 2024
@oderayi oderayi added the oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it label Mar 4, 2024
@oderayi oderayi closed this as completed Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-dev-squad oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it PI-23 story
Projects
Status: Done
Development

No branches or pull requests

3 participants