Helm release upgrades from v12.0.0 fail when changing the Mojaloop-Simulator Helm Chart version

[mdebarros]

Summary:

Helm release upgrades from v12.0.0 fail when upgrading the Mojaloop-Simulator Helm Chart version:

The Deployment "dev3-sim-payeefsp-scheme-adapter" is invalid: MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable

Severity:
Medium

Priority:
Medium

Expected Behavior

Upgrades from 12.0.0 to 12.x.x should be successful.

Steps to Reproduce

1. Install v12.0.0 with default config
2. Upgrade v12.0.0 to v12.1.0 (WIP: feat(release): v13.0.0 wip (v12.1.0 earlier) helm#436) with default config

Specifications

• Component (if known): Helm
• Version: v12.x.x
• Platform: Helm
• Subsystem: Mojaloop-Simulators Helm Chart
• Type of testing: Manual
• Bug found/raised by: @mdebarros

Notes:

• Severity when opened: Medium
• Priority when opened: Medium

[mdebarros]

The issue is caused due to labels not following best practices, specifically:

Selector labels (such as app.kubernetes.io/name) should not contain any Helm version-specific or release-specific information as the selector-fields are immutable:

The Deployment "dev3-sim-payeefsp-scheme-adapter" is invalid: MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable

WIP [Helm release v12.1.0] includes changes to Mojaloop-Simulator specification to align labels to best practices -> mojaloop/helm@1b8c0bb.

This, unfortunately, means that v12.1.0 Helm Release will be breaking. As such the version was bumped up to v13.0.0 to reflect this.

[elnyry-sam-k]

@mdebarros would you recommend enhancing/fixing mojaloop simulator chart to avoid this issue in the future?

[mdebarros]

@mdebarros would you recommend enhancing/fixing mojaloop simulator chart to avoid this issue in the future?

I have aligned the selectorLabels to best practices in Helm v13.0.0 release, and this issue should not impact upgrades going forward.